From: Jonas Dreßler Date: Wed, 16 Feb 2022 12:07:34 +0000 (+0100) Subject: st/scroll-view: Don't queue redraw in update_fade_effect() X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~516^2^2~77 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8f4427f87b4ba4d9b24d5302fef4c0a57a8652ac;p=gnome-shell.git st/scroll-view: Don't queue redraw in update_fade_effect() ClutterEffects are responsible for queueing redraws when their properties change (and StScrollViewFade is a good citizen already), also Clutter itself should queue a redraw when adding/removing an effect. Users of Clutter should never have to queue redraws themselves (unless they're implementing a custom ClutterEffect or ClutterContent), so don't queue a redraw here. Part-of: --- diff --git a/src/st/st-scroll-view.c b/src/st/st-scroll-view.c index 7dedc45b4..cf13ccee0 100644 --- a/src/st/st-scroll-view.c +++ b/src/st/st-scroll-view.c @@ -206,8 +206,6 @@ st_scroll_view_update_fade_effect (StScrollView *scroll, priv->fade_effect = NULL; } } - - clutter_actor_queue_redraw (CLUTTER_ACTOR (scroll)); } static void